A plugin's kind and where it came from wear the same grey pill, and one of them is missing entirely #184
Labels
No labels
accessibility
authentication
breaking change
bug
documentation
enhancement
interface
internationalisation
observability
security
tier
1
tier
2
tier
3
tier/4
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
Postulo/postulo#184
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Observation
Two different facts about a plugin are drawn identically, and on the page where people
actually manage their plugins one of them is not drawn at all.
server/plugins.htmlshows both, in the same pill:Same shape, same grey, side by side. Nothing tells a reader that importer and official
are answers to different questions.
settings/plugins.html:47shows the kind, in that same grey pill, and no provenance atall — so the page a person uses to turn their own plugins on and off never says where any
of them came from.
What it should be
makes eight categories scannable in a list. The kinds are in
plugins/policy.py:source,notifier,store,sync,importer,feature(governed) andtransport,identifier(ungoverned). Eight.Grey is not a default here — it is the existing argument, and it is right
server/plugins.htmlalready explains why provenance is not styled to reassure:A green Official badge reads as a safety rating, and it is not one. Keeping provenance grey
while the kind takes colour is the same argument made visually: the colourful tag is a
category, the grey one is a fact about origin that nobody should read as an endorsement.
There are four origins, not three
plugins/provenance.pyalready has the whole vocabulary, labels and explanations included —nothing needs inventing:
internalofficialcustomuploadeduploadedis the one to be careful about. #94's own opening says why it exists:So a design that offers three origins has to decide what an uploaded plugin shows, and the
answer cannot be "official". It has a label already; it should keep it.
Worth getting right
nobody replaces the word with a dot. Both themes need real contrast —
app.cssalready hasthe 100/500/700 ramps for amber, emerald and the rest — and eight distinguishable hues is
more than a palette usually gives, so some kinds may share and lean on the word.
app.cssalready has.chipand friends; these wantthe same treatment rather than eight inline class strings repeated across two templates.
data-provenanceis load-bearing.server/plugins.htmlcarries it on the pill and thee2e tests read it; whatever this becomes keeps that attribute and its
title.Landed on
0.3.0as934ea6301.Kind coloured, origin grey and now shown on the settings page too, both drawn through one partial so they cannot drift apart again.
policy.overviewgained the provenance that page never had. Four new strings, in French and both Portuguese catalogues.