THIRD-PARTY.md: the committed NACE table and the GeoNames and ESCO data are missing from the register #579

New issue

Closed

opened 2026-10-01 10:47:47 +00:00 by tiagoagueda · 0 comments

tiagoagueda commented

2026-10-01 10:47:47 +00:00

Owner

Found on 2026-09-29 in a read-only review of postulo at 95348908d and postulo.wiki at de1f52467, listing every licence file in the tree against the register.

Related to #279.

Checked again on 2026-10-01 against main at 0a5cad587: still present.

THIRD-PARTY.md says that "a work committed here and not listed, fails the suite", yet jobs/data/nace-2.1.json (Eurostat's NACE Rev. 2.1, CC BY 4.0, with jobs/data/LICENCE.md beside it) is committed and not listed, and the suite passes. The wiki also sends readers to "the registry's line" for GeoNames in THIRD-PARTY.md, which does not exist; ESCO, downloaded under the Commission's CC BY 4.0 with ESCO-LICENCE.md committed, has no line either.

Where: THIRD-PARTY.md:11-23 (the claim and the table: Lucide, flag-icons, Tailwind CSS, basecoat-css, htmx, @zxcvbn-ts, Natural Earth, Buy Me a Coffee); jobs/data/LICENCE.md, jobs/data/GEONAMES-LICENCE.md, jobs/data/ESCO-LICENCE.md; wiki Configuration.md:107-109; tests/test_trademarks.py:36-57, whose THIRD_PARTY dict is a fixed list of directories, so a new one is never checked.
What happens: a packager or redistributor reads the register to learn which attributions the tree and an installed instance carry, misses three datasets under attribution licences, and follows the wiki to a line that is not there.
Fix: add a row for NACE Rev. 2.1 (src/postulo/jobs/data/nace-2.1.json, Eurostat / Publications Office, CC BY 4.0, notice LICENCE.md beside it). Add a short section for data downloaded at provisioning rather than committed, with GeoNames (CC BY 3.0, fetch_geonames, GEONAMES-LICENCE.md) and ESCO (CC BY 4.0, fetch_esco, ESCO-LICENCE.md), since the register's "Nothing above is fetched at run time" does not fit them. Add src/postulo/jobs/data to THIRD_PARTY in the test, and add a test that every *LICEN[CS]E* or NOTICE* file under src/ and assets/ sits in a directory the register names.

Done when

tests/test_trademarks.py fails on today's register (the licence files in src/postulo/jobs/data/ are not registered) and passes once the rows are added.

Found on 2026-09-29 in a read-only review of postulo at 95348908d and postulo.wiki at de1f52467, listing every licence file in the tree against the register. Related to #279. Checked again on 2026-10-01 against `main` at `0a5cad587`: still present. THIRD-PARTY.md says that "a work committed here and not listed, fails the suite", yet `jobs/data/nace-2.1.json` (Eurostat's NACE Rev. 2.1, CC BY 4.0, with `jobs/data/LICENCE.md` beside it) is committed and not listed, and the suite passes. The wiki also sends readers to "the registry's line" for GeoNames in THIRD-PARTY.md, which does not exist; ESCO, downloaded under the Commission's CC BY 4.0 with `ESCO-LICENCE.md` committed, has no line either. - **Where:** `THIRD-PARTY.md:11-23` (the claim and the table: Lucide, flag-icons, Tailwind CSS, basecoat-css, htmx, @zxcvbn-ts, Natural Earth, Buy Me a Coffee); `jobs/data/LICENCE.md`, `jobs/data/GEONAMES-LICENCE.md`, `jobs/data/ESCO-LICENCE.md`; wiki `Configuration.md:107-109`; `tests/test_trademarks.py:36-57`, whose `THIRD_PARTY` dict is a fixed list of directories, so a new one is never checked. - **What happens:** a packager or redistributor reads the register to learn which attributions the tree and an installed instance carry, misses three datasets under attribution licences, and follows the wiki to a line that is not there. - **Fix:** add a row for NACE Rev. 2.1 (`src/postulo/jobs/data/nace-2.1.json`, Eurostat / Publications Office, CC BY 4.0, notice `LICENCE.md` beside it). Add a short section for data downloaded at provisioning rather than committed, with GeoNames (CC BY 3.0, `fetch_geonames`, `GEONAMES-LICENCE.md`) and ESCO (CC BY 4.0, `fetch_esco`, `ESCO-LICENCE.md`), since the register's "Nothing above is fetched at run time" does not fit them. Add `src/postulo/jobs/data` to `THIRD_PARTY` in the test, and add a test that every `*LICEN[CS]E*` or `NOTICE*` file under `src/` and `assets/` sits in a directory the register names. ## Done when - `tests/test_trademarks.py` fails on today's register (the licence files in `src/postulo/jobs/data/` are not registered) and passes once the rows are added.

tiagoagueda added this to the 0.6.0 milestone

2026-10-01 10:47:47 +00:00

tiagoagueda added the

documentation

tier

labels

2026-10-01 10:47:47 +00:00

tiagoagueda referenced this issue

2026-10-03 01:58:35 +00:00

Write down the contribution rules: look for a library before writing one, and the formats data leaves in #653

tiagoagueda referenced this issue

2026-10-03 01:58:36 +00:00