Captures API: give GET /captures a normalised address, or a count of distinct postings, so the extension need not copy same_url() #711
Labels
No labels
accessibility
authentication
breaking change
bug
documentation
enhancement
interface
internationalisation
observability
performance
security
tier
1
tier
2
tier
3
tier/4
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
Postulo/postulo#711
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Left over from postulo-chromium#5 (toolbar badge, commit
5f66750).The extension counts the postings waiting for review once per address, merging Postulo's list with its own unsent captures. To do so it carries a port of the core's
same_url()(src/lib/address.js, with 31 cases of its own). Two copies of one rule drift: the daysame_url()changes, the badge and the review list disagree with Postulo about what is one posting.What to do
GET /api/v1/captures, the address assame_url()normalises it, orcountthat is of postings, not of captures) beside the list.Done when
same_url().same_url()returns for the stored address.src/lib/address.js(its own issue on that repository).