Masthead search on Documents and the Calendar: their own things first, everything on request #848

New issue

Closed

opened 2026-10-10 16:01:21 +00:00 by tiagoagueda · 1 comment

tiagoagueda commented

2026-10-10 16:01:21 +00:00

Owner

What exists today

templates/cotton/site_search.html has two modes: everything (default) and this table ({% block site_search %}, :76-103) with a search this table submit, a globe Search everything button (formaction="{% url 'core:search' %}") and live narrowing. Listings, Applications and Companies use the second; Documents and the Calendar the first.
None of the Documents lists reads q (documents/views.py: CVListView :186-195 no filter, letters ?kind=, files ?kind=&proves=, sent). Global search has the groups (core/search.py: search_letters :361, search_cvs :385, search_uploads :409, search_sent :460) with no list to send All N to (#506).
The Calendar has no text search: agenda.page_for filters by ?kinds= and the period only; reminders are a global group (search_reminders, core/search.py:327), interviews and deadlines are not.

What would change

Documents: each list takes q (on a core Table, or the parts site search needs: search_label, search, search_keeps), an id'd filter form and swap target, and the site_search block; All N in global search links to them.
Calendar: q over the events of the shown period, and the same block.

Decisions

Documents across its four lists, or the list on screen. Recommended: the list on screen, as the other sections do; Search everything is one button away.
Calendar scope. Recommended: the period shown, with a line saying so, rather than all time.

Interacts with #833 (the search on phones).

Checked against main at 8c3d03570. From the maintainer's improvements list of 2026-10-07.

On Documents the masthead search should search documents by default, and on the Calendar events and reminders, with an option to search everything — as Listings, Applications and Companies already do. ## What exists today - `templates/cotton/site_search.html` has two modes: *everything* (default) and *this table* (`{% block site_search %}`, `:76-103`) with a *search this table* submit, a globe *Search everything* button (`formaction="{% url 'core:search' %}"`) and live narrowing. Listings, Applications and Companies use the second; Documents and the Calendar the first. - **None of the Documents lists reads `q`** (`documents/views.py`: `CVListView :186-195` no filter, letters `?kind=`, files `?kind=&proves=`, sent). Global search has the groups (`core/search.py`: `search_letters :361`, `search_cvs :385`, `search_uploads :409`, `search_sent :460`) with no list to send *All N* to (#506). - **The Calendar has no text search**: `agenda.page_for` filters by `?kinds=` and the period only; reminders are a global group (`search_reminders`, `core/search.py:327`), interviews and deadlines are not. ## What would change - Documents: each list takes `q` (on a core `Table`, or the parts site search needs: `search_label`, `search`, `search_keeps`), an id'd filter form and swap target, and the `site_search` block; *All N* in global search links to them. - Calendar: `q` over the events of the shown period, and the same block. ## Decisions - **Documents across its four lists, or the list on screen.** Recommended: the list on screen, as the other sections do; *Search everything* is one button away. - **Calendar scope.** Recommended: the period shown, with a line saying so, rather than all time. Interacts with #833 (the search on phones). Checked against `main` at `8c3d03570`. From the maintainer's improvements list of 2026-10-07.

tiagoagueda added this to the 0.6.0 milestone

2026-10-10 16:01:21 +00:00

tiagoagueda added the

enhancement

interface

labels

2026-10-10 16:01:21 +00:00

tiagoagueda self-assigned this

2026-10-11 10:51:46 +00:00

tiagoagueda commented

2026-10-11 17:43:37 +00:00

Author