Company form: remove an identifier with a bin and a confirmation, not a checkbox #857

New issue

Closed

opened 2026-10-10 16:01:27 +00:00 by tiagoagueda · 1 comment

tiagoagueda commented

2026-10-10 16:01:27 +00:00

Owner

Replace the Remove checkbox on a company's identifier rows with a bin icon that removes at once after a confirmation dialog.

What exists today

templates/cotton/identifier_row.html:63-66: the formset's DELETE box, applied on Save.
Your details already does it the other way: remove_at_once (:61-62) draws <c-remove-button :removal="row.removal"> (trash-2, popovertarget) and a <c-dialog action=… live data-remove-row> outside the form (profile.html:307, :336-349; accounts/removals.py).

What would change

A removal endpoint for CompanyIdentifier, row.removal set in the company view, and the dialogs drawn after </form>.

Note #759 (PST-030): the formset discloses whether another account's identifier id exists; a removal endpoint must check ownership the same way.

Checked against main at 8c3d03570. From the maintainer's improvements list of 2026-10-07.

Replace the *Remove* checkbox on a company's identifier rows with a bin icon that removes at once after a confirmation dialog. ## What exists today - `templates/cotton/identifier_row.html:63-66`: the formset's `DELETE` box, applied on Save. - Your details already does it the other way: `remove_at_once` (`:61-62`) draws `<c-remove-button :removal="row.removal">` (`trash-2`, `popovertarget`) and a `<c-dialog action=… live data-remove-row>` outside the form (`profile.html:307`, `:336-349`; `accounts/removals.py`). ## What would change - A removal endpoint for `CompanyIdentifier`, `row.removal` set in the company view, and the dialogs drawn after `</form>`. Note #759 (PST-030): the formset discloses whether another account's identifier id exists; a removal endpoint must check ownership the same way. Checked against `main` at `8c3d03570`. From the maintainer's improvements list of 2026-10-07.

tiagoagueda added this to the 0.6.0 milestone

2026-10-10 16:01:27 +00:00

tiagoagueda added the

interface

enhancement

labels

2026-10-10 16:01:27 +00:00

tiagoagueda self-assigned this

2026-10-10 17:49:59 +00:00

tiagoagueda commented

2026-10-11 10:32:24 +00:00

Author