Rename “Companies on a map” to “Maps”, credit its data and code in the interface, and give it the map icon #882

New issue

Closed

opened 2026-10-10 16:11:41 +00:00 by tiagoagueda · 1 comment

tiagoagueda commented

2026-10-10 16:11:41 +00:00

Owner

The module will become broader, so rename Companies on a map to Maps; credit, in its description, all the code and data it uses; give it the Lucide map icon.

What exists today

plugins/maps/__init__.py:27-45, label Companies on a map, description Show where the companies are on a map, and place a company from the town typed in its location, using a table of cities kept on this server…; the logic is jobs/mapping.py.
Credits are only in the repository: THIRD-PARTY.md:22 (Natural Earth, public domain) and :37 (GeoNames, CC BY 3.0). Nothing in the interface credits GeoNames, whose licence asks for attribution where the data is used — the map page mentions GeoNames only when the data set has not been downloaded (templates/jobs/company_map.html:74). Leaflet and any tile source arrive with #702.

What would change

Label Maps; description saying what it does now and what it may do (#702, #703).
Credits in the description and as a line on the map page itself: Places from GeoNames (CC BY 3.0); world outline from Natural Earth; later Leaflet's and the tile source's.
The map icon, added to assets/icons.txt.
The internal name maps stays.

Checked against main at 8c3d03570. From the maintainer's improvements list of 2026-10-07 (plugins).

The module will become broader, so rename **Companies on a map** to **Maps**; credit, in its description, all the code and data it uses; give it the Lucide `map` icon. ## What exists today - `plugins/maps/__init__.py:27-45`, label *Companies on a map*, description *Show where the companies are on a map, and place a company from the town typed in its location, using a table of cities kept on this server…*; the logic is `jobs/mapping.py`. - **Credits are only in the repository**: `THIRD-PARTY.md:22` (Natural Earth, public domain) and `:37` (GeoNames, **CC BY 3.0**). Nothing in the interface credits GeoNames, whose licence asks for attribution where the data is used — the map page mentions GeoNames only when the data set has not been downloaded (`templates/jobs/company_map.html:74`). Leaflet and any tile source arrive with #702. ## What would change - Label *Maps*; description saying what it does now and what it may do (#702, #703). - Credits in the description and as a line on the map page itself: *Places from GeoNames (CC BY 3.0); world outline from Natural Earth*; later Leaflet's and the tile source's. - The `map` icon, added to `assets/icons.txt`. - The internal name `maps` stays. Checked against `main` at `8c3d03570`. From the maintainer's improvements list of 2026-10-07 (plugins).

tiagoagueda added this to the 0.6.0 milestone

2026-10-10 16:11:41 +00:00

tiagoagueda added the

interface

enhancement

bug

labels

2026-10-10 16:11:41 +00:00

tiagoagueda self-assigned this

2026-10-11 10:50:25 +00:00

tiagoagueda commented

2026-10-11 15:46:59 +00:00