Companies' map: zoom and locate on the left, attribution in the bottom-right corner #907
Labels
No labels
accessibility
authentication
breaking change
bug
documentation
enhancement
interface
internationalisation
observability
performance
security
tier
1
tier
2
tier
3
tier/4
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
Postulo/postulo#907
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
On the companies' map, the zoom and locate buttons move to the left, and the attribution (Leaflet · tile credit) sits in the bottom-right corner.
What exists today
position: "bottomright"(static/js/app.js:7448-7454for zoom,:7362forLocate). The comment there says they are bottom right to stay clear of the heading over the top of the map (#849).app.js:7461), so it shares the corner with the buttons..map-stage .leaflet-bottom(static/css/app.css:8522) lifts every bottom corner 6.5rem (3rem fromsm) to clear the footer and the drawer. That means the attribution floats above the corner instead of sitting in it.templates/jobs/company_map.html: headingstart-3 top-3, drawerend-3 top-3fromsm(inset-x-3 bottom-14below that), status bottom centre, footerstart-3 bottom-3.What would change
bottomleft, above the footer. The lift stays for that corner only (.leaflet-bottom.leaflet-left).bottomrightwith no lift: it sits flush in the bottom-right corner of the map,bottom: 0; right: 0.app.jsto say where the buttons are now and why.To check
sm, the footer spans the full width atbottom-3and the drawer isinset-x-3 bottom-14, so the attribution in the corner can collide with the footer. Either the footer leaves room at the end, or the attribution goes under it.bottomleft/bottomrightare physical, while the overlays use logicalstart/end. In RTL the buttons would land on the footer's side, so the positions should followdir.Checked against
mainate1c6b4e9a.Fixed in
eadae8b6e. The attribution half is superseded by #908, which made the credit the end of the footer's line.