Social profiles: clicking the address prefix puts the cursor in the username box #924
Labels
No labels
accessibility
authentication
breaking change
bug
documentation
enhancement
interface
internationalisation
observability
performance
security
tier
1
tier
2
tier
3
tier/4
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
Postulo/postulo#924
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
In a social profile's row (and a code repository's), clicking the service's fixed address prefix in front of the username puts the cursor in the username box. The whole group (prefix and box) shows the focus ring.
What exists today
templates/partials/web_links.html(#678): with a service chosen, the address is Basecoat'sinput-group(data-address-group). The prefix is<span data-align="start" id="<url id>_prefix"><bdi dir="ltr">https://…/</bdi></span>followed by theurlinput, and the input isaria-describedbythe prefix. The prefix is text, not a label. Clicking it selects text and does not focus the box.assets/css/basecoat.css:.input-groupalready draws the ring on the group whenever anything inside it has focus (focus-within:border-brand-500 focus-within:ring-2 …). Once the box has focus, the group is ringed. The missing part is the click on the prefix. (#868 dealt with a focused address field being ringed twice. Check that this does not bring that back.)[data-phone-field]) and the country-and-flag group have the same shape.What would change
<label>(it already has one above, "Username"; a second label element pointing at the box is allowed and keeps it script-free), orapp.js, delegatemousedownon[data-address-group] > spantoinput.focus()and prevent the text selection.focus-within, so the CSS needs no change. Check that only one ring is drawn (#868).Accessibility
<label>would make the prefix part of the name. If so, take it out ofaria-describedbyso it is not read twice.No new strings.
Related: #678, #868, #305.
Checked against
mainat56fc9d531.