Your details on phones: scrolled, the page's name replaces the instance's name and logo in the masthead #930

Closed
opened 2026-10-15 17:19:50 +00:00 by tiagoagueda · 0 comments
Owner

On a phone held upright, scrolling Your details until its heading leaves the screen makes "Your details" appear where the instance's name ("Postulo") is in the masthead, and the Postulo logo is no longer drawn.

What exists today

  • templates/base.html: the masthead's first item is the wordmark <a … data-wordmark>, which holds <img src="{% static 'brand/logo-64.png' %}" …> and {{ instance_name }}. The header is sticky top-0.
  • The only script that reads the page's heading is the section observer in static/js/app.js (#869, "The label over the list says 'On this page' until the page's own heading has scrolled behind the masthead, and then names the page"). It uses document.querySelector("main h1") and changes the sidebar's label [data-section-label], not the masthead. It does so only while matchMedia("(min-width: 64rem)") matches, so never on a phone.
  • The masthead's search on phones (#833) hides the wordmark while the search box is open ([data-site-header][data-search-open] [data-wordmark] in assets/css/app.css). Nothing found here swaps the wordmark for the page's name.

What is wrong

  • Reported: the page's name replaces the instance's name, and the logo goes. The cause was not found by reading the code, so reproduce it first. Things to rule out: the section label (data-section-label, which takes larger type through data-away-class) drawn over the masthead because the aside's lg:sticky or the strip misbehaves below lg; the breadcrumb (#831/#832) when it is switched on; the browser's own toolbar in an installed app (#895/#899) showing the document's title.

Expected

  • The masthead always shows the logo and the instance's name at every scroll position. Only #869's label changes, and only from lg up, inside the sidebar.

To check

  • A browser test at 360px: scroll Your details to the bottom and assert that the wordmark's text is still instance_name and its image is visible.

Related: #869, #833, #831, #195, #929.

Checked against main at 56fc9d531.

On a phone held upright, scrolling *Your details* until its heading leaves the screen makes "Your details" appear where the instance's name ("Postulo") is in the masthead, and the Postulo logo is no longer drawn. ## What exists today - `templates/base.html`: the masthead's first item is the wordmark `<a … data-wordmark>`, which holds `<img src="{% static 'brand/logo-64.png' %}" …>` and `{{ instance_name }}`. The header is `sticky top-0`. - The only script that reads the page's heading is the section observer in `static/js/app.js` (#869, "The label over the list says 'On this page' until the page's own heading has scrolled behind the masthead, and then names the page"). It uses `document.querySelector("main h1")` and changes **the sidebar's label** `[data-section-label]`, not the masthead. It does so only while `matchMedia("(min-width: 64rem)")` matches, so never on a phone. - The masthead's search on phones (#833) hides the wordmark while the search box is open (`[data-site-header][data-search-open] [data-wordmark]` in `assets/css/app.css`). Nothing found here swaps the wordmark for the page's name. ## What is wrong - Reported: the page's name replaces the instance's name, and the logo goes. The cause was not found by reading the code, so reproduce it first. Things to rule out: the section label (`data-section-label`, which takes larger type through `data-away-class`) drawn over the masthead because the aside's `lg:sticky` or the strip misbehaves below `lg`; the breadcrumb (#831/#832) when it is switched on; the browser's own toolbar in an installed app (#895/#899) showing the document's title. ## Expected - The masthead always shows the logo and the instance's name at every scroll position. Only #869's label changes, and only from `lg` up, inside the sidebar. ## To check - A browser test at 360px: scroll Your details to the bottom and assert that the wordmark's text is still `instance_name` and its image is visible. Related: #869, #833, #831, #195, #929. Checked against `main` at `56fc9d531`.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
Postulo/postulo#930
No description provided.