Your details on phones: scrolled, the page's name replaces the instance's name and logo in the masthead #930
Labels
No labels
accessibility
authentication
breaking change
bug
documentation
enhancement
interface
internationalisation
observability
performance
security
tier
1
tier
2
tier
3
tier/4
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
Postulo/postulo#930
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
On a phone held upright, scrolling Your details until its heading leaves the screen makes "Your details" appear where the instance's name ("Postulo") is in the masthead, and the Postulo logo is no longer drawn.
What exists today
templates/base.html: the masthead's first item is the wordmark<a … data-wordmark>, which holds<img src="{% static 'brand/logo-64.png' %}" …>and{{ instance_name }}. The header issticky top-0.static/js/app.js(#869, "The label over the list says 'On this page' until the page's own heading has scrolled behind the masthead, and then names the page"). It usesdocument.querySelector("main h1")and changes the sidebar's label[data-section-label], not the masthead. It does so only whilematchMedia("(min-width: 64rem)")matches, so never on a phone.[data-site-header][data-search-open] [data-wordmark]inassets/css/app.css). Nothing found here swaps the wordmark for the page's name.What is wrong
data-section-label, which takes larger type throughdata-away-class) drawn over the masthead because the aside'slg:stickyor the strip misbehaves belowlg; the breadcrumb (#831/#832) when it is switched on; the browser's own toolbar in an installed app (#895/#899) showing the document's title.Expected
lgup, inside the sidebar.To check
instance_nameand its image is visible.Related: #869, #833, #831, #195, #929.
Checked against
mainat56fc9d531.