Your details: a question mark beside the heading and on every section #1014

Merged
tiagoagueda merged 3 commits from 918-details-help-marks into main 2026-10-21 18:36:15 +00:00
Owner

Closes #918

What changed

  • Your details uses one help pattern: a question mark after the H1 (<c-page-title help="your-details">, no subtitle) and one at the top right of every section, each with its one sentence as the tooltip and the full text in the drawer.
  • New topics your-details (the Settings link moves into its drawer), cv-photo, personal-details, messaging, each with a templates/help/<slug>.html.
  • Your CV photo, Personal details and Messaging get their marks; Personal details keeps the id personal-details-help that its fieldsets are described by. The paragraph and the CV-photo subtitle are gone.
  • The kept-in-sight instructions (data-links-how, data-identifiers-how) are now the second half of the card's sentence (a slot of c-help-mark); they stay under the heading while something is refused. c-page-title passes in_sight through so that rule holds for the H1.
  • Phone report: not reproduced. No rule hides the subtitle by width; the mark and its 24px target are shown at 390px and 1280px, held by a new browser test.
  • Tests: test_help_topics.py, e2e/test_help.py (first/last focus stop is now the heading's mark), e2e/test_details_on_phones.py.
  • Wiki: Accessibility and Design pages (local commit, not pushed).

Library check

None needed.

Model use

Written with Claude Code, reviewed by the person who opens the PR.

🤖 Generated with Claude Code

Closes #918 ## What changed - Your details uses one help pattern: a question mark after the H1 (`<c-page-title help="your-details">`, no subtitle) and one at the top right of every section, each with its one sentence as the tooltip and the full text in the drawer. - New topics `your-details` (the Settings link moves into its drawer), `cv-photo`, `personal-details`, `messaging`, each with a `templates/help/<slug>.html`. - Your CV photo, Personal details and Messaging get their marks; Personal details keeps the id `personal-details-help` that its fieldsets are described by. The paragraph and the CV-photo subtitle are gone. - The kept-in-sight instructions (`data-links-how`, `data-identifiers-how`) are now the second half of the card's sentence (a slot of `c-help-mark`); they stay under the heading while something is refused. `c-page-title` passes `in_sight` through so that rule holds for the H1. - Phone report: not reproduced. No rule hides the subtitle by width; the mark and its 24px target are shown at 390px and 1280px, held by a new browser test. - Tests: `test_help_topics.py`, `e2e/test_help.py` (first/last focus stop is now the heading's mark), `e2e/test_details_on_phones.py`. - Wiki: Accessibility and Design pages (local commit, not pushed). ## Library check None needed. ## Model use Written with Claude Code, reviewed by the person who opens the PR. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
Your details: a question mark beside the heading and on every section
Some checks failed
CI / Unit tests and coverage (Python 3.14) (push) Successful in 12m13s
CI / Checks: lint, migrations, catalogues, settings, built files (push) Successful in 2m26s
CI / Database tests on PostgreSQL (push) Successful in 3m14s
CI / Security audit (push) Successful in 40s
CI / Browser tests (Chromium) (push) Failing after 30m27s
Every Python / Unit tests (Python 3.12) (push) Successful in 12m13s
Every Python / Unit tests (Python 3.13) (push) Successful in 12m5s
CI / Browser tests (Chromium) (pull_request) Failing after 30m3s
CI / Unit tests and coverage (Python 3.14) (pull_request) Successful in 12m23s
CI / Database tests on PostgreSQL (pull_request) Successful in 4m56s
CI / Checks: lint, migrations, catalogues, settings, built files (pull_request) Successful in 2m59s
CI / Security audit (pull_request) Successful in 1m14s
ff9c512280
Help on this page had three shapes: a sentence under the H1, a sentence or a
paragraph under some section headings, and a question mark on only some
sections. Listings and Documents already draw one pattern, a mark after the H1
with the sentence as its tooltip and the full text in the drawer, so Your
details now does too.

New topics your-details (page, with the Settings link in the drawer), cv-photo,
personal-details and messaging, each with a help template. The H1, Your CV
photo, Personal details and Messaging carry the mark and no text under them;
Personal details keeps the id its fieldsets are described by. The two
instructions kept in sight since #302 (what may be pasted into Identifiers, what
to type on a card of links) are now the second half of the card's sentence, a
slot of c-help-mark; they and every sentence stay under their headings while
something is refused. c-page-title passes in_sight through so that rule holds
for the H1 too.

The phone report (no helper text and no mark under the H1) was not reproduced:
no rule hides the subtitle by width, and the mark and its 24px target are shown
at 390px and 1280px, which a new browser test holds.

Closes #918

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Merge main into 918-details-help-marks
Some checks failed
CI / Checks: lint, migrations, catalogues, settings, built files (push) Successful in 2m53s
CI / Browser tests (Chromium) (push) Failing after 31m12s
Every Python / Unit tests (Python 3.12) (push) Successful in 13m41s
Every Python / Unit tests (Python 3.13) (push) Successful in 13m46s
CI / Unit tests and coverage (Python 3.14) (push) Successful in 14m3s
CI / Database tests on PostgreSQL (push) Successful in 3m47s
CI / Security audit (push) Failing after 48s
CI / Unit tests and coverage (Python 3.14) (pull_request) Successful in 12m8s
CI / Database tests on PostgreSQL (pull_request) Successful in 3m34s
CI / Security audit (pull_request) Failing after 45s
CI / Checks: lint, migrations, catalogues, settings, built files (pull_request) Successful in 2m35s
CI / Browser tests (Chromium) (pull_request) Successful in 29m28s
14e76adce5
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Merge remote-tracking branch 'origin/main' into HEAD
Some checks failed
CI / Unit tests and coverage (Python 3.14) (push) Successful in 13m30s
CI / Checks: lint, migrations, catalogues, settings, built files (push) Successful in 2m24s
CI / Database tests on PostgreSQL (push) Successful in 3m30s
CI / Security audit (push) Failing after 43s
CI / Browser tests (Chromium) (push) Successful in 29m3s
Every Python / Unit tests (Python 3.12) (push) Successful in 14m31s
CI / Checks: lint, migrations, catalogues, settings, built files (pull_request) Successful in 3m15s
CI / Database tests on PostgreSQL (pull_request) Successful in 4m13s
CI / Browser tests (Chromium) (pull_request) Successful in 33m1s
CI / Security audit (pull_request) Successful in 1m14s
Every Python / Unit tests (Python 3.13) (push) Successful in 15m47s
CI / Unit tests and coverage (Python 3.14) (pull_request) Successful in 14m44s
54e6de6972
tiagoagueda deleted branch 918-details-help-marks 2026-10-21 18:36:18 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
Postulo/postulo!1014
No description provided.