Donate to Postulo/postulo

• https://buymeacoffee.com/tiagoagueda

---

See the documentation for more details on donation links.

One behaviour for phones, addresses and social profiles on a company, a contact and Your details #1018

Merged

tiagoagueda merged 2 commits from 934-contact-details-parity into main 2026-10-22 01:19:31 +00:00

Conversation 0 Commits 2 Files changed 108 +1934 -183

tiagoagueda commented 2026-10-19 18:02:42 +00:00

Owner

• Copy link
• Copy Markdown

Closes #934

What changed

• Your details builds its numbers and addresses through PhoneNumbersMixin and PostalAddressesMixin, as a company and a contact do; its own get_numbers and get_addresses are gone.
• A company's and a contact's forms get the star for primary, the bin that removes a row at once and the help mark, as Your details has them. The bin needed two new routes, jobs:company_remove_row and jobs:contact_remove_row (POST, write access to the holder, a row of another holder is a 404).
• A browser fills a telephone box only on the person's own numbers (tel), off on a company's or a contact's, as it already did for addresses. The widget template had tel hard-coded; it now follows the field.
• A contact's card on its company's page lists its postal addresses.
• A company's vCard carries its mailbox, every number and address, its website and its social profiles; importing one reads them back, and _not_kept only names a second website, the title and messaging handles. The profile's card still prints the primary only (a CV choice), now documented.
• API: a contact takes and returns phone_numbers, postal_addresses and web_links; phone, phone_country and linkedin_url are kept as aliases, marked deprecated in the schema, with a CHANGELOG line under Deprecated.
• Deliberate differences (phone uniqueness and account recovery only on the profile, social links only for a company, a company's addresses always on the map, the printed primary) are in the docstrings of PhoneNumber, PostalAddress and WebLink and in the wiki, and each is pinned by a test in tests/test_contact_details_parity.py.

Already done on main (left alone)

#932 (the LinkedIn company prefix), the extension advice and the postal autofill.

Tests

tests/test_contact_details_parity.py (new). Three older tests pinned the old shapes and were updated: test_a_contacts_form_keeps_its_help_in_sight, test_the_contact_form_keeps_its_boxes and the Gets me back in page check (now about the rows, the help drawer being the topic's one text). The page-coverage and isolation sweeps list the two new routes. Full unit suite green; the browser tests for the company and contact forms, row removal, phone groups and accessibility pass.

Library check

None needed.

Model use

Written with Claude Code, reviewed by the person who opens the PR.

🤖 Generated with Claude Code

Closes #934 ## What changed - Your details builds its numbers and addresses through `PhoneNumbersMixin` and `PostalAddressesMixin`, as a company and a contact do; its own `get_numbers` and `get_addresses` are gone. - A company's and a contact's forms get the star for primary, the bin that removes a row at once and the help mark, as Your details has them. The bin needed two new routes, `jobs:company_remove_row` and `jobs:contact_remove_row` (POST, write access to the holder, a row of another holder is a 404). - A browser fills a telephone box only on the person's own numbers (`tel`), `off` on a company's or a contact's, as it already did for addresses. The widget template had `tel` hard-coded; it now follows the field. - A contact's card on its company's page lists its postal addresses. - A company's vCard carries its mailbox, every number and address, its website and its social profiles; importing one reads them back, and `_not_kept` only names a second website, the title and messaging handles. The profile's card still prints the primary only (a CV choice), now documented. - API: a contact takes and returns `phone_numbers`, `postal_addresses` and `web_links`; `phone`, `phone_country` and `linkedin_url` are kept as aliases, marked deprecated in the schema, with a CHANGELOG line under Deprecated. - Deliberate differences (phone uniqueness and account recovery only on the profile, social links only for a company, a company's addresses always on the map, the printed primary) are in the docstrings of `PhoneNumber`, `PostalAddress` and `WebLink` and in the wiki, and each is pinned by a test in `tests/test_contact_details_parity.py`. ## Already done on main (left alone) #932 (the LinkedIn company prefix), the extension advice and the postal autofill. ## Tests `tests/test_contact_details_parity.py` (new). Three older tests pinned the old shapes and were updated: `test_a_contacts_form_keeps_its_help_in_sight`, `test_the_contact_form_keeps_its_boxes` and the *Gets me back in* page check (now about the rows, the help drawer being the topic's one text). The page-coverage and isolation sweeps list the two new routes. Full unit suite green; the browser tests for the company and contact forms, row removal, phone groups and accessibility pass. ## Library check None needed. ## Model use Written with Claude Code, reviewed by the person who opens the PR. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

tiagoagueda added 1 commit 2026-10-19 18:02:42 +00:00

One behaviour for phones, addresses and social profiles on a company, a contact and Your details (#934) ... b370951278

The three owners stored their rows in the same tables but edited, showed,
exported and offered them through the API differently, by accident rather
than by intent. This makes them the same and writes down, with a test each,
the differences that are deliberate.

- Your details builds its numbers and addresses through PhoneNumbersMixin and
  PostalAddressesMixin like the other two; its own get_numbers and
  get_addresses are gone.
- A company's and a contact's forms get the star, the bin that removes a row
  at once (new jobs:company_remove_row and jobs:contact_remove_row, write
  access to the holder required) and the help mark, as Your details has them.
- A browser fills a telephone box only on the person's own numbers
  (autocomplete tel, off elsewhere), as it already did for addresses.
- A contact's card on its company's page lists its postal addresses.
- A company's vCard carries its mailbox, every number and address, its website
  and its social profiles, and importing one reads them back. Your own card
  keeps the printed primary only: that is a choice about a document.
- The API: a contact takes and returns phone_numbers, postal_addresses and
  web_links lists; the single phone, phone_country and linkedin_url stay as
  deprecated aliases.
- Deliberate differences (phone uniqueness and account recovery only on the
  profile, social links only for a company, a company's addresses always on the
  map) are in the shared models' docstrings and pinned by tests.

Already done on main and left alone: the company LinkedIn prefix (#932), the
extension advice and postal autofill.

Closes #934

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

tiagoagueda added 1 commit 2026-10-22 01:19:13 +00:00

Merge main into 934-contact-details-parity ... 73e74dd941

The company card keeps both the contact-details parity of this branch and the legal-state
note of main; the contact the API creates is made by the surface service and then given its
numbers and addresses as rows. The two remove-row routes are write routes in the sharing
sweep, as the identifier one is.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

tiagoagueda merged commit 3181a9ec01 into main 2026-10-22 01:19:31 +00:00

tiagoagueda referenced this pull request from a commit 2026-10-22 01:19:32 +00:00

One behaviour for phones, addresses and social profiles on a company, a contact and Your details (#1018)

tiagoagueda deleted branch 934-contact-details-parity 2026-10-22 01:19:36 +00:00

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

accessibility

Usable by everyone, including people with disabilities: one of the project's stated missions

  

authentication

Signing in, and proving who you are

  

breaking change

Changes behaviour or data in a way operators must act on

  

bug

Something does not do what it says it does

  

documentation

The wiki, the docs, or the words in the interface

  

enhancement

An improvement or a new capability

  

interface

The shape of the pages: what is where, and how it reads

  

internationalisation

Languages, regions, and the formats and symbols that go with them

  

observability

What an operator can see about a running instance: metrics, logs, health

  

performance

Uses fewer resources, or is more reliable, with no loss of features or accessibility

  

security

Keeping the code and the data secure: one of the project's stated missions

  

tier

1

Easy: small, self-contained, no prerequisites

  

tier

2

High-severity security: account access, personal data, the boundaries

  

tier

3

Foundations: prerequisite work that unblocks other issues

  

tier/4

Later: large features and long-horizon work

No labels

accessibility

authentication

breaking change

bug

documentation

enhancement

interface

internationalisation

observability

performance

security

tier

1

tier

2

tier

3

tier/4

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

Postulo/postulo!1018

No description provided.