Postulo/postulo

Watch

Fork 0

Escape closes the panel a button opened, whatever its tooltip remembers #1028

Merged

tiagoagueda merged 2 commits from 917-escape-panel into main

2026-10-21 09:37:50 +00:00

tiagoagueda commented

2026-10-21 06:47:46 +00:00

Owner

Refs #917. Follow-up to #1015 and #1025.

What changed

app.js, the Escape handler for tooltips: before it decides whether a tooltip takes the key, a tooltip place whose anchor is a popovertarget button for a panel that is open now is marked spent. The panel gets the first Escape.

Why

#1025 marked the button's place spent when the panel opened. CI still failed test_the_keyboard_opens_it_and_escape_closes_it_and_returns_the_focus on a loaded runner (run 1138, which has #1025): a place made afresh after the toggle, by a late hover or focus event, starts with spent false and takes the first Escape. Deciding at Escape time, from what is open, does not depend on how the places were rebuilt.

A panel opened by something else, such as the masthead's New menu, still leaves the focused field's tooltip its Escape (test_escape_puts_it_away_and_does_nothing_else).

Tests

test_help.py, test_map.py, test_page_help.py, test_company_names_popover.py and test_birth_picker.py: 79 passed, 6 skipped. The race itself I cannot make happen on this machine, so CI under load is the real check.

Library check

None needed.

🤖 Generated with Claude Code

Refs #917. Follow-up to #1015 and #1025. ## What changed `app.js`, the Escape handler for tooltips: before it decides whether a tooltip takes the key, a tooltip place whose anchor is a `popovertarget` button for a panel that is open now is marked spent. The panel gets the first Escape. ## Why #1025 marked the button's place spent when the panel opened. CI still failed `test_the_keyboard_opens_it_and_escape_closes_it_and_returns_the_focus` on a loaded runner (run 1138, which has #1025): a place made afresh after the toggle, by a late hover or focus event, starts with `spent` false and takes the first Escape. Deciding at Escape time, from what is open, does not depend on how the places were rebuilt. A panel opened by something else, such as the masthead's *New* menu, still leaves the focused field's tooltip its Escape (`test_escape_puts_it_away_and_does_nothing_else`). ## Tests `test_help.py`, `test_map.py`, `test_page_help.py`, `test_company_names_popover.py` and `test_birth_picker.py`: 79 passed, 6 skipped. The race itself I cannot make happen on this machine, so CI under load is the real check. ## Library check None needed. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

tiagoagueda added 1 commit

2026-10-21 06:47:46 +00:00

Escape closes the panel a button opened, whatever its tooltip remembers (#917 )

CI / Checks: lint, migrations, catalogues, settings, built files (push) Successful in 2m42s

Details

CI / Unit tests and coverage (Python 3.14) (push) Successful in 13m52s

Details

CI / Database tests on PostgreSQL (push) Successful in 4m5s

Details

CI / Security audit (push) Failing after 58s

Details

CI / Browser tests (Chromium) (push) Successful in 29m49s

Details

Every Python / Unit tests (Python 3.12) (push) Successful in 13m7s

Details

Every Python / Unit tests (Python 3.13) (push) Successful in 14m13s

Details

CI / Browser tests (Chromium) (pull_request) Failing after 35m25s

Details

CI / Unit tests and coverage (Python 3.14) (pull_request) Successful in 16m35s

Details

CI / Checks: lint, migrations, catalogues, settings, built files (pull_request) Successful in 3m20s

Details

CI / Database tests on PostgreSQL (pull_request) Successful in 4m23s

Details

CI / Security audit (pull_request) Failing after 1m0s

Details

93f70e9ac7

The first fix put the opening button's tooltip away when the panel opened. CI still saw the
company-names popover keep its first Escape for the tooltip: a place made afresh after the
panel opened (a late hover or focus event) starts unspent. The rule is now applied when
Escape is pressed, from what is open at that moment.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

tiagoagueda added 1 commit

2026-10-21 08:01:15 +00:00

Merge remote-tracking branch 'origin/main' into 917-escape-panel

CI / Security audit (push) Successful in 1m8s

Details

CI / Unit tests and coverage (Python 3.14) (push) Successful in 13m21s

Details

CI / Checks: lint, migrations, catalogues, settings, built files (push) Successful in 2m59s

Details

CI / Database tests on PostgreSQL (push) Successful in 4m11s

Details

CI / Checks: lint, migrations, catalogues, settings, built files (pull_request) Successful in 2m50s