Edit a reminder to noon, not to the same hour three days on #1032

Merged

tiagoagueda merged 1 commit from dst-reminder-edit into main

2026-10-22 00:56:05 +00:00

tiagoagueda commented

2026-10-22 00:32:13 +00:00

Owner

test_editing_a_reminder_moves_it_and_unstamps_it failed in CI with a 200 where it expected the 302 of a saved form.

Cause

The test posts "now, three days on" as the new time. Run at 02:30 Paris time on 22 October (00:30 UTC), that is 02:30 on Sunday 25 October, the hour the clocks go back and which happens twice. The form refuses a time that is ambiguous, so it answered 200 with an error. The test failed on this machine too at 00:30 UTC; it fails for the hour from 02:00 to 03:00 Paris time on the days of the year that land three days before the change, and passes the rest of the time.

What changed

The test posts noon, three days on, a time that no clock change repeats.

Tests

tests/test_deadlines.py: 48 passed, run at 00:31 UTC, inside the window where the old test fails.

The other tests that build a time from localtime(...) + days (test_interviews.py, test_appointments.py, test_insights.py) carry the same hazard only if their offset lands on the repeated hour; none failed in the same run, so I have left them alone.

Library check

None needed.

🤖 Generated with Claude Code

`test_editing_a_reminder_moves_it_and_unstamps_it` failed in CI with a 200 where it expected the 302 of a saved form. ## Cause The test posts "now, three days on" as the new time. Run at 02:30 Paris time on 22 October (00:30 UTC), that is 02:30 on Sunday 25 October, the hour the clocks go back and which happens twice. The form refuses a time that is ambiguous, so it answered 200 with an error. The test failed on this machine too at 00:30 UTC; it fails for the hour from 02:00 to 03:00 Paris time on the days of the year that land three days before the change, and passes the rest of the time. ## What changed The test posts noon, three days on, a time that no clock change repeats. ## Tests `tests/test_deadlines.py`: 48 passed, run at 00:31 UTC, inside the window where the old test fails. The other tests that build a time from `localtime(...) + days` (`test_interviews.py`, `test_appointments.py`, `test_insights.py`) carry the same hazard only if their offset lands on the repeated hour; none failed in the same run, so I have left them alone. ## Library check None needed. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

tiagoagueda added 1 commit

2026-10-22 00:32:13 +00:00

Edit a reminder to noon, not to the same hour three days on

CI / Unit tests and coverage (Python 3.14) (pull_request) Successful in 14m39s

Details

CI / Checks: lint, migrations, catalogues, settings, built files (pull_request) Successful in 2m35s

Details

CI / Database tests on PostgreSQL (pull_request) Failing after 39s

Details

CI / Security audit (pull_request) Successful in 1m0s

Details

CI / Browser tests (Chromium) (pull_request) Successful in 34m36s

Details

c6d1a0f632

Taken from now, 'three days on' was 02:30 on the Sunday the clocks go back when the suite ran
at 02:30 Paris time, a time that happens twice, and the form refuses it.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

tiagoagueda merged commit fcd4c2d864 into main

2026-10-22 00:56:05 +00:00

tiagoagueda deleted branch dst-reminder-edit

2026-10-22 00:56:06 +00:00

tiagoagueda referenced this pull request from a commit

2026-10-22 00:56:07 +00:00

Edit a reminder to noon, not to the same hour three days on (#1032)

tiagoagueda referenced this pull request

2026-10-22 01:06:16 +00:00

CI: make a push report sooner and cost less, without new hardware #1033