Find the company form's Save button in the form itself #1035

Merged

tiagoagueda merged 1 commit from company-form-save into main

2026-10-22 09:58:14 +00:00

tiagoagueda commented

2026-10-22 07:03:09 +00:00

Owner

test_the_company_form_is_two_columns_on_a_wide_screen fails on main and fails again when run alone: company_form_parts found no box for the Save button.

Cause

It took .last of main form button[type="submit"], written when the only forms after the company's were none (the logo dialog's came before it, #853). The Edit page now draws forms of its own after the company's: the names in other languages (#917) and the hiring entries (#941). The last submit button on the page became one of theirs, inside a closed <details>, which has no box.

What changed

The test finds Save in the company's own form, the only <form> with no action: main form:not([action]) button[type="submit"].

Tests

tests/e2e/test_width.py: 20 passed, including this test and the below-the-breakpoint and right-to-left ones that share company_form_parts.

Library check

None needed.

🤖 Generated with Claude Code

`test_the_company_form_is_two_columns_on_a_wide_screen` fails on `main` and fails again when run alone: `company_form_parts` found no box for the Save button. ## Cause It took `.last` of `main form button[type="submit"]`, written when the only forms after the company's were none (the logo dialog's came before it, #853). The Edit page now draws forms of its own after the company's: the names in other languages (#917) and the hiring entries (#941). The last submit button on the page became one of theirs, inside a closed `<details>`, which has no box. ## What changed The test finds Save in the company's own form, the only `<form>` with no `action`: `main form:not([action]) button[type="submit"]`. ## Tests `tests/e2e/test_width.py`: 20 passed, including this test and the below-the-breakpoint and right-to-left ones that share `company_form_parts`. ## Library check None needed. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

tiagoagueda added 1 commit

2026-10-22 07:03:09 +00:00

Find the company form's Save button in the form itself

CI / Unit tests and coverage (Python 3.14) (pull_request) Successful in 12m26s

Details

CI / Checks: lint, migrations, catalogues, settings, built files (pull_request) Successful in 2m27s

Details

CI / Database tests on PostgreSQL (pull_request) Successful in 3m27s

Details

CI / Security audit (pull_request) Successful in 42s

Details

CI / Browser tests (Chromium) (pull_request) Successful in 29m19s

Details

a27491d0b6

The test took the last submit button under main form. The Edit page now has forms of its own
after the company's: the names (#917) and the hiring entries (#941), each with submit buttons,
the last of them inside a closed details. The company's form is the one without an action.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

tiagoagueda merged commit 7c19ba3eb1 into main

2026-10-22 09:58:14 +00:00

tiagoagueda deleted branch company-form-save

2026-10-22 09:58:14 +00:00

tiagoagueda referenced this pull request from a commit

2026-10-22 09:58:16 +00:00

Find the company form's Save button in the form itself (#1035)