Donate to Postulo/postulo

• https://buymeacoffee.com/tiagoagueda

---

See the documentation for more details on donation links.

Draw a map pin as its holder's logo or picture, where there is one (#914) #1057

Merged

tiagoagueda merged 1 commit from 914-picture-pins into main 2026-10-27 23:14:00 +00:00

Conversation 0 Commits 1 Files changed 8 +230 -14

tiagoagueda commented 2026-10-27 14:50:14 +00:00

Owner

• Copy link
• Copy Markdown

Closes #914

A map pin whose holder has a picture is drawn as that picture.

• A company's pin is its logo, rounded like its tile.
• The person's own address is their picture, round.
• Everything else keeps the dot: contacts, which have no picture field, and companies without a logo.
• Initials tiles are not used as pins. The issue asked for this to be confirmed: a field of coloured letters reads worse than dots.

How

• Server: each entry in drawn gains picture, the same stamped address the {% company_logo %} / {% avatar %} tags use. Both tags now get it from logo_url() / avatar_url(), which the map reuses.
• Client: a picture pin is a PictureIcon, an L.DivIcon subclass, holding Basecoat's avatar (<span class="avatar rounded|rounded-full"><img alt="">).
  • The icon is built only when Leaflet draws the marker, so pins inside a cluster ask for nothing. Each picture is requested once its pin is on the map, never all of them as the page opens.
  • It is built with DOM nodes, never from markup.
  • An error listener on the canvas, in the capture phase, gives a marker whose picture fails to load its dot back with setIcon. The dot then stays for later redraws as well.
• Accessibility: the marker keeps its title and alt, so the inner image stays decorative (alt=""). The target stays 24px: a 20px picture with a 2px ring.
• Ring: the brand's colour, drawn as an outline because a forced-colours theme drops box-shadows. Under forced colours it is CanvasText.
• Legal state (#941): a dissolved company's picture is greyscale with a grey ring; one in administration gets an amber ring. The title still names the state.
• Clusters are unchanged.

Checked

• Access: jobs:company_logo checks shared_scope(..., READ) and accounts:avatar checks access as before. Both are same-origin, so the CSP needs no change. Responses are private, max-age=86400 behind the ?v= stamp, so redraws hit the cache.
• Tests:
  • tests/test_company_map.py: which entries carry which picture, and the guarantees of the fallback and the accessible name.
  • tests/e2e/test_map.py: a stored logo is drawn and loads, with no CSP breaches. A logo flag with nothing behind it (404) falls back to the dot.
• No new strings.

🤖 Generated with Claude Code

Closes #914 A map pin whose holder has a picture is drawn as that picture. - **A company's pin is its logo**, rounded like its tile. - **The person's own address is their picture**, round. - **Everything else keeps the dot:** contacts, which have no picture field, and companies without a logo. - **Initials tiles are not used as pins.** The issue asked for this to be confirmed: a field of coloured letters reads worse than dots. ## How - **Server:** each entry in `drawn` gains `picture`, the same stamped address the `{% company_logo %}` / `{% avatar %}` tags use. Both tags now get it from `logo_url()` / `avatar_url()`, which the map reuses. - **Client:** a picture pin is a `PictureIcon`, an `L.DivIcon` subclass, holding Basecoat's `avatar` (`<span class="avatar rounded|rounded-full"><img alt="">`). - The icon is **built only when Leaflet draws the marker**, so pins inside a cluster ask for nothing. Each picture is requested once its pin is on the map, never all of them as the page opens. - It is built with DOM nodes, never from markup. - An `error` listener on the canvas, in the capture phase, gives a marker whose picture fails to load its dot back with `setIcon`. The dot then stays for later redraws as well. - **Accessibility:** the marker keeps its `title` and `alt`, so the inner image stays decorative (`alt=""`). The target stays 24px: a 20px picture with a 2px ring. - **Ring:** the brand's colour, drawn as an `outline` because a forced-colours theme drops box-shadows. Under forced colours it is `CanvasText`. - **Legal state (#941):** a dissolved company's picture is greyscale with a grey ring; one in administration gets an amber ring. The title still names the state. - **Clusters** are unchanged. ## Checked - **Access:** `jobs:company_logo` checks `shared_scope(..., READ)` and `accounts:avatar` checks access as before. Both are same-origin, so the CSP needs no change. Responses are `private, max-age=86400` behind the `?v=` stamp, so redraws hit the cache. - **Tests:** - `tests/test_company_map.py`: which entries carry which picture, and the guarantees of the fallback and the accessible name. - `tests/e2e/test_map.py`: a stored logo is drawn and loads, with no CSP breaches. A logo flag with nothing behind it (404) falls back to the dot. - No new strings. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

tiagoagueda added 1 commit 2026-10-27 14:50:14 +00:00

Draw a map pin as its holder's logo or picture, where there is one (#914) ... 3c1f83b982

A company's pin is its logo, rounded as its tile is, and the person's own address is their
picture, round, each in Basecoat's avatar ringed in the brand's colour (an outline, which a
forced-colours theme keeps). A contact, a company without a logo, and an initials tile keep
the dot. The marker keeps its title and alt, so the picture inside is decorative; it is
built only when Leaflet draws the marker, so a picture is asked for once its pin leaves a
cluster; and one that fails to load gives its marker the dot back.

Closes #914

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

tiagoagueda force-pushed 914-picture-pins from 3c1f83b982 to 7a59a09532 2026-10-27 15:13:23 +00:00 Compare

tiagoagueda force-pushed 914-picture-pins from 7a59a09532 to 23a66c9405 2026-10-27 16:45:46 +00:00 Compare

tiagoagueda force-pushed 914-picture-pins from 23a66c9405 to 855b4d241a 2026-10-27 23:11:35 +00:00 Compare

tiagoagueda merged commit 45f4bad0b2 into main 2026-10-27 23:14:00 +00:00

tiagoagueda deleted branch 914-picture-pins 2026-10-27 23:14:00 +00:00

tiagoagueda referenced this pull request from a commit 2026-10-27 23:14:02 +00:00

Draw a map pin as its holder's logo or picture, where there is one (#914) (#1057)

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

accessibility

Usable by everyone, including people with disabilities: one of the project's stated missions

  

authentication

Signing in, and proving who you are

  

breaking change

Changes behaviour or data in a way operators must act on

  

bug

Something does not do what it says it does

  

documentation

The wiki, the docs, or the words in the interface

  

enhancement

An improvement or a new capability

  

interface

The shape of the pages: what is where, and how it reads

  

internationalisation

Languages, regions, and the formats and symbols that go with them

  

observability

What an operator can see about a running instance: metrics, logs, health

  

performance

Uses fewer resources, or is more reliable, with no loss of features or accessibility

  

security

Keeping the code and the data secure: one of the project's stated missions

  

tier

1

Easy: small, self-contained, no prerequisites

  

tier

2

High-severity security: account access, personal data, the boundaries

  

tier

3

Foundations: prerequisite work that unblocks other issues

  

tier/4

Later: large features and long-horizon work

No labels

accessibility

authentication

breaking change

bug

documentation

enhancement

interface

internationalisation

observability

performance

security

tier

1

tier

2

tier

3

tier/4

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

Postulo/postulo!1057

No description provided.