Donate to Postulo/postulo

• https://buymeacoffee.com/tiagoagueda

---

See the documentation for more details on donation links.

Group a language's variants in the picker, and pick one for a bare tag (#1053) #1064

Merged

tiagoagueda merged 1 commit from 1053-language-picker into main 2026-10-27 21:23:06 +00:00

Conversation 0 Commits 1 Files changed 100 +744 -1126

tiagoagueda commented 2026-10-27 16:08:34 +00:00

Owner

• Copy link
• Copy Markdown

Five languages are offered in more than one form, and the picker listed
each form as an entry of its own, grouped by how well it was translated:
português (Portugal) and português (Brasil) could sit under two headings.

Every language menu now shows a language's variants under its own name,
through one function, accounts.forms.grouped_by_language: the select on
Server settings -> Defaults, the document, record and CV language menus
(all LanguageSelect), and the rows of Settings -> Language and time.
The heading is CLDR's name for the language in itself, capitalised as
CLDR asks of a menu (Português, Español, Français, English, 中文), and
carries its lang; under it a variant is its country in its own language
(Brasil, México, United Kingdom; es reads as España), and Chinese is
named by script (简体中文, 繁體中文). A language offered in one form stays a
plain option. The closed control shows the whole name (data-chosen).
language_choices is flat now; the translation state stays on the rows.

Each option and row also carries the words it can be found by: its own
name, CLDR's English one and its name in the interface language, so the
box over a long select and the Settings search find Deutsch for
"German". Without scripts the plain select, with its groups, still works.

A browser asking for plain pt, es, fr, en or zh is given pt-BR, es-MX,
fr-FR, en-GB or zh-Hans (languages.DEFAULT_VARIANTS), in LocaleMiddleware;
a header that names a variant first still gets it. Where the instance
does not offer the form asked for, a visitor gets another offered form
of the same language before the instance default.

Closes #1053

Notes for review

• The maintainer's decisions (2026-10-27):
  • Variants are grouped under their language.
  • A bare tag lands on the most-spoken variant: pt→pt-BR, es→es-MX, fr→fr-FR, en→en-GB, zh→zh-Hans.
  • Chinese is labelled by script.
  • A filter matches native and English names.
• Decisions the issue left open:
  • language_choices() is flat now, because an <optgroup> cannot nest. So the Server defaults select loses its "Reviewed / Awaiting review / Partly translated" headings. Partial languages keep their percentage, and Settings still shows each language's state.
  • For a visitor, preferences.fallback tries another offered form of the same language before the instance default.
  • es-419 and es-AR still go to es (Spain). Only bare tags are remapped.
• Sign-up has no language picker, so it is not changed.
• Also updated: docs/TRANSLATING.md.

🤖 Generated with Claude Code

Five languages are offered in more than one form, and the picker listed each form as an entry of its own, grouped by how well it was translated: português (Portugal) and português (Brasil) could sit under two headings. Every language menu now shows a language's variants under its own name, through one function, accounts.forms.grouped_by_language: the select on Server settings -> Defaults, the document, record and CV language menus (all LanguageSelect), and the rows of Settings -> Language and time. The heading is CLDR's name for the language in itself, capitalised as CLDR asks of a menu (Português, Español, Français, English, 中文), and carries its lang; under it a variant is its country in its own language (Brasil, México, United Kingdom; es reads as España), and Chinese is named by script (简体中文, 繁體中文). A language offered in one form stays a plain option. The closed control shows the whole name (data-chosen). language_choices is flat now; the translation state stays on the rows. Each option and row also carries the words it can be found by: its own name, CLDR's English one and its name in the interface language, so the box over a long select and the Settings search find Deutsch for "German". Without scripts the plain select, with its groups, still works. A browser asking for plain pt, es, fr, en or zh is given pt-BR, es-MX, fr-FR, en-GB or zh-Hans (languages.DEFAULT_VARIANTS), in LocaleMiddleware; a header that names a variant first still gets it. Where the instance does not offer the form asked for, a visitor gets another offered form of the same language before the instance default. Closes #1053 ## Notes for review - **The maintainer's decisions (2026-10-27):** - Variants are grouped under their language. - A bare tag lands on the most-spoken variant: `pt`→`pt-BR`, `es`→`es-MX`, `fr`→`fr-FR`, `en`→`en-GB`, `zh`→`zh-Hans`. - Chinese is labelled by script. - A filter matches native and English names. - **Decisions the issue left open:** - `language_choices()` is flat now, because an `<optgroup>` cannot nest. So the Server defaults select loses its "Reviewed / Awaiting review / Partly translated" headings. Partial languages keep their percentage, and Settings still shows each language's state. - For a visitor, `preferences.fallback` tries another offered form of the same language before the instance default. - `es-419` and `es-AR` still go to `es` (Spain). Only bare tags are remapped. - **Sign-up** has no language picker, so it is not changed. - **Also updated:** `docs/TRANSLATING.md`. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

tiagoagueda added 1 commit 2026-10-27 16:08:34 +00:00

Group a language's variants in the picker, and pick one for a bare tag (#1053) ... 96b24936aa

Five languages are offered in more than one form, and the picker listed
each form as an entry of its own, grouped by how well it was translated:
português (Portugal) and português (Brasil) could sit under two headings.

Every language menu now shows a language's variants under its own name,
through one function, accounts.forms.grouped_by_language: the select on
Server settings -> Defaults, the document, record and CV language menus
(all LanguageSelect), and the rows of Settings -> Language and time.
The heading is CLDR's name for the language in itself, capitalised as
CLDR asks of a menu (Português, Español, Français, English, 中文), and
carries its lang; under it a variant is its country in its own language
(Brasil, México, United Kingdom; es reads as España), and Chinese is
named by script (简体中文, 繁體中文). A language offered in one form stays a
plain option. The closed control shows the whole name (data-chosen).
language_choices is flat now; the translation state stays on the rows.

Each option and row also carries the words it can be found by: its own
name, CLDR's English one and its name in the interface language, so the
box over a long select and the Settings search find Deutsch for
"German". Without scripts the plain select, with its groups, still works.

A browser asking for plain pt, es, fr, en or zh is given pt-BR, es-MX,
fr-FR, en-GB or zh-Hans (languages.DEFAULT_VARIANTS), in LocaleMiddleware;
a header that names a variant first still gets it. Where the instance
does not offer the form asked for, a visitor gets another offered form
of the same language before the instance default.

Closes #1053

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

tiagoagueda force-pushed 1053-language-picker from 96b24936aa to 4eab1bdb39 2026-10-27 21:22:56 +00:00 Compare

tiagoagueda merged commit ef840e2e28 into main 2026-10-27 21:23:06 +00:00

tiagoagueda referenced this pull request from a commit 2026-10-27 21:23:07 +00:00

Group a language's variants in the picker, and pick one for a bare tag (#1053) (#1064)

tiagoagueda deleted branch 1053-language-picker 2026-10-27 21:23:09 +00:00

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

accessibility

Usable by everyone, including people with disabilities: one of the project's stated missions

  

authentication

Signing in, and proving who you are

  

breaking change

Changes behaviour or data in a way operators must act on

  

bug

Something does not do what it says it does

  

documentation

The wiki, the docs, or the words in the interface

  

enhancement

An improvement or a new capability

  

interface

The shape of the pages: what is where, and how it reads

  

internationalisation

Languages, regions, and the formats and symbols that go with them

  

observability

What an operator can see about a running instance: metrics, logs, health

  

performance

Uses fewer resources, or is more reliable, with no loss of features or accessibility

  

security

Keeping the code and the data secure: one of the project's stated missions

  

tier

1

Easy: small, self-contained, no prerequisites

  

tier

2

High-severity security: account access, personal data, the boundaries

  

tier

3

Foundations: prerequisite work that unblocks other issues

  

tier/4

Later: large features and long-horizon work

No labels

accessibility

authentication

breaking change

bug

documentation

enhancement

interface

internationalisation

observability

performance

security

tier

1

tier

2

tier

3

tier/4

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

Postulo/postulo!1064

No description provided.