Donate to Postulo/postulo

• https://buymeacoffee.com/tiagoagueda

---

See the documentation for more details on donation links.

Put reminders on the plugin surface, with a service each to create, change, move, complete and reopen them (#331) #1080

Merged

tiagoagueda merged 1 commit from 331-reminder-services into main 2026-10-29 18:31:25 +00:00

Conversation 0 Commits 1 Files changed 104 +2122 -77

tiagoagueda commented 2026-10-28 16:09:40 +00:00

Owner

• Copy link
• Copy Markdown

A plugin keeping a CalDAV task list in step (postulo-dav#12) could not reach Reminder,
and Postulo itself made, ticked and unticked reminders by hand in a dozen places.

• create_reminder, change_reminder, postpone_reminder (now with an actor),
  complete_reminder and reopen_reminder in applications.services, each taking an
  actor. Another person's application is a ValueError, the summary is cut to 250
  characters, a date means nine in the morning in the owner's zone (outside any request
  too), complete_reminder refuses a moment in the future, and reopening does not
  announce the reminder again.
• add_reminder makes a new entry through create_reminder (and complete_reminder when
  it arrives done): the uid-keyed, source-guarded way in is layered over the one general
  act, not a second writer beside it. It takes an optional actor, which the calendar
  import now passes.
• Every caller moved onto them: the create and edit forms, Done, Snooze, the API's add,
  change and complete, the interview, appointment and offer paths (the offer path no longer
  clears done_at by hand). The importer and the demo seed stay as they were; a test
  guards the rest of the tree.
• Decision 1 (a): Reminder.actor names who last touched it when it was not the person,
  drawn beside it as "via ..." on the calendar and an application's page, on the API's
  ReminderOut, and in the archive (format 77).
• Decision 3 (b): Not done in a done reminder's menu, and
  POST /api/v1/reminders/{id}/reopen.
• Reminder and the five services are on api.__all__ and _ELSEWHERE; change_status
  stays off.

Closes #331

Notes for review

• Five services: create_reminder, change_reminder, postpone_reminder, complete_reminder and reopen_reminder. Each takes an actor, and they are on the plugin surface with Reminder.
  • add_reminder (#887) is now a thin caller of create_reminder.
  • Every caller is moved onto them. A guard test fails on any reminder made or completed by hand outside the services, the importer and the demo seed.
• The maintainer's decisions (the issue's recommendations):
  • a Reminder.actor column, shown as "via …";
  • change_status stays off the surface;
  • reopen from the page (Not done) and the API (POST /api/v1/reminders/{id}/reopen);
  • reopening doesn't announce again.
• Behaviour changes worth a look:
  • Editing a done reminder's time is refused on the form ("It is already done."), where before it was saved silently.
  • A moved appointment no longer moves a done reminder.
  • The offer's answer-by reminder falls due at 09:00 in the owner's zone, not the active zone.
• Archive format: 77, plus migration applications 0021_reminder_actor. #878 (PR #1061) also takes 77, so whichever lands second takes 78.

🤖 Generated with Claude Code

A plugin keeping a CalDAV task list in step (postulo-dav#12) could not reach `Reminder`, and Postulo itself made, ticked and unticked reminders by hand in a dozen places. - `create_reminder`, `change_reminder`, `postpone_reminder` (now with an actor), `complete_reminder` and `reopen_reminder` in `applications.services`, each taking an `actor`. Another person's application is a ValueError, the summary is cut to 250 characters, a date means nine in the morning in the owner's zone (outside any request too), `complete_reminder` refuses a moment in the future, and reopening does not announce the reminder again. - `add_reminder` makes a new entry through `create_reminder` (and `complete_reminder` when it arrives done): the uid-keyed, source-guarded way in is layered over the one general act, not a second writer beside it. It takes an optional `actor`, which the calendar import now passes. - Every caller moved onto them: the create and edit forms, Done, Snooze, the API's add, change and complete, the interview, appointment and offer paths (the offer path no longer clears `done_at` by hand). The importer and the demo seed stay as they were; a test guards the rest of the tree. - Decision 1 (a): `Reminder.actor` names who last touched it when it was not the person, drawn beside it as "via ..." on the calendar and an application's page, on the API's `ReminderOut`, and in the archive (format 77). - Decision 3 (b): *Not done* in a done reminder's menu, and `POST /api/v1/reminders/{id}/reopen`. - `Reminder` and the five services are on `api.__all__` and `_ELSEWHERE`; `change_status` stays off. Closes #331 ## Notes for review - **Five services:** `create_reminder`, `change_reminder`, `postpone_reminder`, `complete_reminder` and `reopen_reminder`. Each takes an `actor`, and they are on the plugin surface with `Reminder`. - `add_reminder` (#887) is now a thin caller of `create_reminder`. - Every caller is moved onto them. A guard test fails on any reminder made or completed by hand outside the services, the importer and the demo seed. - **The maintainer's decisions (the issue's recommendations):** - a `Reminder.actor` column, shown as "via …"; - `change_status` stays off the surface; - reopen from the page (*Not done*) and the API (`POST /api/v1/reminders/{id}/reopen`); - reopening doesn't announce again. - **Behaviour changes worth a look:** - Editing a done reminder's time is refused on the form ("It is already done."), where before it was saved silently. - A moved appointment no longer moves a done reminder. - The offer's answer-by reminder falls due at 09:00 in the owner's zone, not the active zone. - **Archive format:** 77, plus migration `applications 0021_reminder_actor`. #878 (PR #1061) also takes 77, so whichever lands second takes 78. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

tiagoagueda added 1 commit 2026-10-28 16:09:40 +00:00

Put reminders on the plugin surface, with a service each to create, change, move, complete and reopen them (#331) ... 5fba2e3bea

A plugin keeping a CalDAV task list in step (postulo-dav#12) could not reach `Reminder`,
and Postulo itself made, ticked and unticked reminders by hand in a dozen places.

- `create_reminder`, `change_reminder`, `postpone_reminder` (now with an actor),
  `complete_reminder` and `reopen_reminder` in `applications.services`, each taking an
  `actor`. Another person's application is a ValueError, the summary is cut to 250
  characters, a date means nine in the morning in the owner's zone (outside any request
  too), `complete_reminder` refuses a moment in the future, and reopening does not
  announce the reminder again.
- `add_reminder` makes a new entry through `create_reminder` (and `complete_reminder` when
  it arrives done): the uid-keyed, source-guarded way in is layered over the one general
  act, not a second writer beside it. It takes an optional `actor`, which the calendar
  import now passes.
- Every caller moved onto them: the create and edit forms, Done, Snooze, the API's add,
  change and complete, the interview, appointment and offer paths (the offer path no longer
  clears `done_at` by hand). The importer and the demo seed stay as they were; a test
  guards the rest of the tree.
- Decision 1 (a): `Reminder.actor` names who last touched it when it was not the person,
  drawn beside it as "via ..." on the calendar and an application's page, on the API's
  `ReminderOut`, and in the archive (format 77).
- Decision 3 (b): *Not done* in a done reminder's menu, and
  `POST /api/v1/reminders/{id}/reopen`.
- `Reminder` and the five services are on `api.__all__` and `_ELSEWHERE`; `change_status`
  stays off.

Closes #331

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

tiagoagueda referenced this pull request 2026-10-28 17:11:12 +00:00

Let a theme set the job-search report, and remember the choice (#340) #1082

tiagoagueda force-pushed 331-reminder-services from 5fba2e3bea to 8b81d56184 2026-10-29 10:01:10 +00:00 Compare

tiagoagueda force-pushed 331-reminder-services from 8b81d56184 to faa9ef68c6 2026-10-29 10:30:01 +00:00 Compare

tiagoagueda referenced this pull request 2026-10-29 10:32:22 +00:00

Let a document be printed on A4 or US Letter, either way up (#344) #1084

tiagoagueda force-pushed 331-reminder-services from faa9ef68c6 to 5a66070a9c 2026-10-29 18:28:11 +00:00 Compare

tiagoagueda merged commit a6a6a5edbf into main 2026-10-29 18:31:25 +00:00

tiagoagueda referenced this pull request from a commit 2026-10-29 18:31:26 +00:00

Put reminders on the plugin surface, with a service each to create, change, move, complete and reopen them (#331) (#1080)

tiagoagueda deleted branch 331-reminder-services 2026-10-29 18:31:27 +00:00

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

accessibility

Usable by everyone, including people with disabilities: one of the project's stated missions

  

authentication

Signing in, and proving who you are

  

breaking change

Changes behaviour or data in a way operators must act on

  

bug

Something does not do what it says it does

  

documentation

The wiki, the docs, or the words in the interface

  

enhancement

An improvement or a new capability

  

interface

The shape of the pages: what is where, and how it reads

  

internationalisation

Languages, regions, and the formats and symbols that go with them

  

observability

What an operator can see about a running instance: metrics, logs, health

  

performance

Uses fewer resources, or is more reliable, with no loss of features or accessibility

  

security

Keeping the code and the data secure: one of the project's stated missions

  

tier

1

Easy: small, self-contained, no prerequisites

  

tier

2

High-severity security: account access, personal data, the boundaries

  

tier

3

Foundations: prerequisite work that unblocks other issues

  

tier/4

Later: large features and long-horizon work

No labels

accessibility

authentication

breaking change

bug

documentation

enhancement

interface

internationalisation

observability

performance

security

tier

1

tier

2

tier

3

tier/4

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

Postulo/postulo!1080

No description provided.