Donate to Postulo/postulo

• https://buymeacoffee.com/tiagoagueda

---

See the documentation for more details on donation links.

Let a connection's form offer what its service has, several chosen with a mode each (#332) #1089

Merged

tiagoagueda merged 1 commit from 332-connection-discovery into main 2026-10-31 05:10:45 +00:00

Conversation 0 Commits 1 Files changed 98 +6445 -45

tiagoagueda commented 2026-10-30 21:15:53 +00:00

Owner

• Copy link
• Copy Markdown

A connection's form was drawn from FieldSpecs whose choices were fixed when
config_fields() ran, so a plugin like DAV could not offer the address books,
calendars and task lists only the server knows about (postulo/postulo-dav#13).

• FieldSpec gains modes and a discovered type. DiscoveredOption (value,
  label, group, modes, note) is on postulo.plugins.api. A connected plugin may
  have an optional discover(config) that returns options keyed by field name.
• A saved connection's form has a "Look on the server" button. Like #688's
  "Look up", it posts the whole form to connections:discover, which works
  without scripts. That view calls discover with the configuration as last
  saved and draws the form back as it was typed. It never runs on page load
  or on Save. It shares Test's allowance (POSTULO_CONNECTION_TEST_RATE), its
  consent check and its error handling, now one helper used by both views,
  and calls the server outside any transaction. A failure is shown in the
  plugin's words and keeps what was found before.
• What was found is kept in the connection's config under
  "postulo:discovered", with when it was found. The field stores option value
  to mode for the chosen options only.
• The field is drawn as a real table with a caption and header cells,
  grouped. Each option has one select labelled by its name, with "Not used"
  first and then the modes that option allows. A chosen option that is no
  longer found keeps its row and last label, marked "No longer on the
  server", until it is set to Not used. validate() sees the choice.
• Connections only. A transport or a backup destination that declares the
  type gets a disabled field with a sentence and stores nothing.

Tests: tests/test_connection_discovery.py, page coverage, the isolation
sweep and an accessibility walk of the form showing found options.

Closes #332

Notes for review

• New field type: discovered (with FieldSpec.modes), for connections only, plus DiscoveredOption on the plugin surface. A connected plugin may implement discover(config).
• Checking what discover returns (plugins/discovery.py): bad items and undeclared modes are dropped, duplicates kept once, at most 200 options of up to 500 characters. The result is kept in the connection's config (postulo:discovered), so no migration.
• The form: one select per found option, with Not used first, then the plugin's modes. Only chosen options are stored, as {value: mode}. An option that is no longer found stays visible, marked gone.
• Look on the server: a POST of the whole form (connections:discover) that never saves. It shares the test button's guard: the same allowance (POSTULO_CONNECTION_TEST_RATE), the consent check, and errors in the plugin's words. It runs outside the request's transaction.
• Transports and backup destinations: the type shows as a disabled field with a sentence, and nothing is stored.
• Decisions the issue left open:
  • discovery uses the configuration as last saved;
  • required is ignored on a discovered field;
  • a plugin's validate problems on it are form-wide.
• Tests: a new browser axe test for the option table, light and dark.

🤖 Generated with Claude Code

A connection's form was drawn from FieldSpecs whose choices were fixed when config_fields() ran, so a plugin like DAV could not offer the address books, calendars and task lists only the server knows about (postulo/postulo-dav#13). - FieldSpec gains `modes` and a `discovered` type. DiscoveredOption (value, label, group, modes, note) is on postulo.plugins.api. A connected plugin may have an optional `discover(config)` that returns options keyed by field name. - A saved connection's form has a "Look on the server" button. Like #688's "Look up", it posts the whole form to connections:discover, which works without scripts. That view calls discover with the configuration as last saved and draws the form back as it was typed. It never runs on page load or on Save. It shares Test's allowance (POSTULO_CONNECTION_TEST_RATE), its consent check and its error handling, now one helper used by both views, and calls the server outside any transaction. A failure is shown in the plugin's words and keeps what was found before. - What was found is kept in the connection's config under "postulo:discovered", with when it was found. The field stores option value to mode for the chosen options only. - The field is drawn as a real table with a caption and header cells, grouped. Each option has one select labelled by its name, with "Not used" first and then the modes that option allows. A chosen option that is no longer found keeps its row and last label, marked "No longer on the server", until it is set to Not used. validate() sees the choice. - Connections only. A transport or a backup destination that declares the type gets a disabled field with a sentence and stores nothing. Tests: tests/test_connection_discovery.py, page coverage, the isolation sweep and an accessibility walk of the form showing found options. Closes #332 ## Notes for review - **New field type:** `discovered` (with `FieldSpec.modes`), for connections only, plus `DiscoveredOption` on the plugin surface. A connected plugin may implement `discover(config)`. - **Checking what `discover` returns** (`plugins/discovery.py`): bad items and undeclared modes are dropped, duplicates kept once, at most 200 options of up to 500 characters. The result is kept in the connection's `config` (`postulo:discovered`), so no migration. - **The form:** one select per found option, with *Not used* first, then the plugin's modes. Only chosen options are stored, as `{value: mode}`. An option that is no longer found stays visible, marked gone. - ***Look on the server*:** a POST of the whole form (`connections:discover`) that never saves. It shares the test button's guard: the same allowance (`POSTULO_CONNECTION_TEST_RATE`), the consent check, and errors in the plugin's words. It runs outside the request's transaction. - **Transports and backup destinations:** the type shows as a disabled field with a sentence, and nothing is stored. - **Decisions the issue left open:** - discovery uses the configuration as last saved; - `required` is ignored on a discovered field; - a plugin's `validate` problems on it are form-wide. - **Tests:** a new browser axe test for the option table, light and dark. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

tiagoagueda added 1 commit 2026-10-30 21:15:53 +00:00

Let a connection's form offer what its service has, several chosen with a mode each (#332) ... d08598980e

A connection's form was drawn from FieldSpecs whose choices were fixed when
config_fields() ran, so a plugin like DAV could not offer the address books,
calendars and task lists only the server knows about (postulo/postulo-dav#13).

- FieldSpec gains `modes` and a `discovered` type. DiscoveredOption (value,
  label, group, modes, note) is on postulo.plugins.api. A connected plugin may
  have an optional `discover(config)` that returns options keyed by field name.
- A saved connection's form has a "Look on the server" button. Like #688's
  "Look up", it posts the whole form to connections:discover, which works
  without scripts. That view calls discover with the configuration as last
  saved and draws the form back as it was typed. It never runs on page load
  or on Save. It shares Test's allowance (POSTULO_CONNECTION_TEST_RATE), its
  consent check and its error handling, now one helper used by both views,
  and calls the server outside any transaction. A failure is shown in the
  plugin's words and keeps what was found before.
- What was found is kept in the connection's config under
  "postulo:discovered", with when it was found. The field stores option value
  to mode for the chosen options only.
- The field is drawn as a real table with a caption and header cells,
  grouped. Each option has one select labelled by its name, with "Not used"
  first and then the modes that option allows. A chosen option that is no
  longer found keeps its row and last label, marked "No longer on the
  server", until it is set to Not used. validate() sees the choice.
- Connections only. A transport or a backup destination that declares the
  type gets a disabled field with a sentence and stores nothing.

Tests: tests/test_connection_discovery.py, page coverage, the isolation
sweep and an accessibility walk of the form showing found options.

Closes #332

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

tiagoagueda force-pushed 332-connection-discovery from d08598980e to 39c4e97560 2026-10-31 02:32:18 +00:00 Compare

tiagoagueda force-pushed 332-connection-discovery from 39c4e97560 to 46252480cf 2026-10-31 05:07:51 +00:00 Compare

tiagoagueda merged commit d60135befe into main 2026-10-31 05:10:45 +00:00

tiagoagueda referenced this pull request from a commit 2026-10-31 05:10:46 +00:00

Let a connection's form offer what its service has, several chosen with a mode each (#332) (#1089)

tiagoagueda deleted branch 332-connection-discovery 2026-10-31 05:10:48 +00:00

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

accessibility

Usable by everyone, including people with disabilities: one of the project's stated missions

  

authentication

Signing in, and proving who you are

  

breaking change

Changes behaviour or data in a way operators must act on

  

bug

Something does not do what it says it does

  

documentation

The wiki, the docs, or the words in the interface

  

enhancement

An improvement or a new capability

  

interface

The shape of the pages: what is where, and how it reads

  

internationalisation

Languages, regions, and the formats and symbols that go with them

  

observability

What an operator can see about a running instance: metrics, logs, health

  

performance

Uses fewer resources, or is more reliable, with no loss of features or accessibility

  

security

Keeping the code and the data secure: one of the project's stated missions

  

tier

1

Easy: small, self-contained, no prerequisites

  

tier

2

High-severity security: account access, personal data, the boundaries

  

tier

3

Foundations: prerequisite work that unblocks other issues

  

tier/4

Later: large features and long-horizon work

No labels

accessibility

authentication

breaking change

bug

documentation

enhancement

interface

internationalisation

observability

performance

security

tier

1

tier

2

tier

3

tier/4

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

Postulo/postulo!1089

No description provided.