Restore a nested reminder's source, note and retired date from an archive (#1081) #1181

Merged

tiagoagueda merged 1 commit from 1081-nested-reminder-import into main

2026-10-31 23:28:48 +00:00

tiagoagueda commented

2026-10-31 15:07:07 +00:00

Owner

An account archive writes source, note and retired_at for every reminder (format 66, #887). The importer read them only for a reminder about no application, so one nested under an application or an appointment came back as if somebody had made it, without its note, and open again.

_reminder_origin(entry) gives all three places the same three fields.
No format change: the archive already carried them.

Tests: tests/test_export.py::test_a_nested_reminder_keeps_its_source_note_and_retired_date fails without the fix and passes with it. tests/test_export.py, tests/test_appointments.py and the reminder tests pass (141).

Closes #1081

🤖 Generated with Claude Code

An account archive writes `source`, `note` and `retired_at` for every reminder (format 66, #887). The importer read them only for a reminder about no application, so one nested under an **application** or an **appointment** came back as if somebody had made it, without its note, and open again. - `_reminder_origin(entry)` gives all three places the same three fields. - No format change: the archive already carried them. **Tests:** `tests/test_export.py::test_a_nested_reminder_keeps_its_source_note_and_retired_date` fails without the fix and passes with it. `tests/test_export.py`, `tests/test_appointments.py` and the reminder tests pass (141). Closes #1081 🤖 Generated with [Claude Code](https://claude.com/claude-code)

tiagoagueda added 1 commit

2026-10-31 15:07:07 +00:00

Restore a nested reminder's source, note and retired date from an archive (#1081 )

CI / Checks: lint, migrations, catalogues, settings, built files (pull_request) Successful in 1m25s

Details

CI / Browser tests (Chromium) (pull_request) Successful in 36m12s

Details

CI / Security audit (pull_request) Successful in 1m1s

Details

CI / Database tests on PostgreSQL (pull_request) Successful in 4m16s

Details

CI / Unit tests and coverage (Python 3.14) (pull_request) Failing after 30m53s

Details

91400828d7

An account archive writes source, note and retired_at for every reminder
(format 66, #887), but the importer read them only for a reminder about no
application: one under an application or an appointment came back as if
somebody had made it, without its note, and open again. One helper,
_reminder_origin, now gives all three places the same fields.

tests/test_export.py: a reminder under an application and one under an
appointment, each with a source, a note and a retired date, come back
identical. No format change: the archive already carried the fields.

Closes #1081

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>